feat(sdk): Verify SDK sync for P004 - includeUndefinedDates revert#1324
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(sdk): Verify SDK sync for P004 - includeUndefinedDates revert#1324yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Verified that Python SDK is already synchronized with gdc-nas revert of includeUndefinedDates feature. The feature was added and reverted in gdc-nas before SDK sync, so no code changes are required. - Confirmed OpenAPI client models lack include_empty_values field - Confirmed SDK filter classes never implemented the feature - Confirmed test suite has no references to reverted fields Related: P004, LX-2032, REVERT-19909 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
|
Close please -> I discovered that when it runs good then it want to create pull request with the specific problem report which it shoudnt... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified that Python SDK is already synchronized with gdc-nas revert of includeUndefinedDates feature.
Jira: (pending - sandbox under maintenance)
Problem: P004 - https://github.com/gooddata/gdc-nas/actions/runs/22064429506
Background
gdc-nas reverted the includeUndefinedDates feature for date filters (LX-2032/REVERT-19909) in commits ef9d814c and 5cfc3bab. The feature was originally added in commit 675dda483c and reverted before SDK synchronization occurred.
Verification Results
✅ OpenAPI Client Models - Already synchronized:
AbsoluteDateFilterAbsoluteDateFilter- noinclude_empty_valuesfieldRelativeDateFilterRelativeDateFilter- noinclude_empty_valuesfield✅ SDK Filter Classes - Never implemented:
AbsoluteDateFilter(gooddata_sdk/compute/model/filter.py)RelativeDateFilter(gooddata_sdk/compute/model/filter.py)✅ Tests - No references to reverted fields:
test_date_filters.py- cleanChanges in gdc-nas
includeEmptyValuesfield from AbsoluteDateFilter and RelativeDateFilter in OpenAPI specsResult
No code changes required. SDK was already in sync with reverted state. Added verification documentation in
.sync-notes/P004-verification.md.Related Issues