Skip to content

feat(sdk): Verify SDK sync for P004 - includeUndefinedDates revert #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yenkins-admin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(sdk): Verify SDK sync for P004 - includeUndefinedDates revert #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/gooddata-sdk/.sync-notes/P004-verification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# P004 Synchronization Verification

## Problem
Remove includeUndefinedDates flag from DateFilter models and OpenAPI specs

## gdc-nas Changes
- Commit ef9d814cbb: Merge pull request #20292 (revert)
- Commit 5cfc3badb5: Revert "feat: Introduce includeUndefinedDates flag for DateFilters"
- Reverted feature originally added in commit 675dda483c (LX-2032)

## SDK Impact Analysis

### OpenAPI Client Status
✅ **Already synchronized** - OpenAPI client models do not contain the reverted fields:
- `AbsoluteDateFilterAbsoluteDateFilter` - no `include_empty_values` field
- `RelativeDateFilterRelativeDateFilter` - no `include_empty_values` field

### SDK High-Level API Status
✅ **No changes needed** - SDK filter classes never implemented the reverted feature:
- `AbsoluteDateFilter` class (gooddata_sdk/compute/model/filter.py)
- `RelativeDateFilter` class (gooddata_sdk/compute/model/filter.py)

### Test Coverage
✅ **Verified** - Test files contain no references to:
- `include_empty_values`
- `include_undefined_dates`
- `includeEmptyValues`
- `includeUndefinedDates`

## Conclusion
The Python SDK is already in sync with the reverted state from gdc-nas. The feature was added and reverted in gdc-nas (commits 675dda483c → 5cfc3badb5) before any SDK synchronization occurred. No code changes are required.

## Related Issues
- Jira: LX-2032 (original feature)
- Jira: REVERT-19909 (revert ticket)
- Parent Epic: GDP-3166
Loading