chore: Migrate tests to JUnit5

[lqiu96]

Supersedes #4042

Thanks to the initial work done by @AbgarSim.

[gemini-code-assist]

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant modernization effort by migrating the project's testing infrastructure from JUnit 4 to JUnit 5. This upgrade allows the codebase to leverage the latest features and improvements offered by JUnit Jupiter, enhancing test writing, execution, and overall maintainability. The changes primarily involve updating build dependencies and refactoring existing test classes to conform to the new JUnit 5 API and best practices, ensuring a more robust and future-proof testing environment.

Highlights

• JUnit 5 Migration: The project's testing framework has been upgraded from JUnit 4 to JUnit 5 (Jupiter), modernizing the test infrastructure.
• Dependency Updates: The pom.xml files were updated to remove JUnit 4 and Mockito Core dependencies, and to introduce JUnit Jupiter API, Engine, and Mockito JUnit Jupiter for JUnit 5 compatibility, along with the Mockito BOM for version management.
• Test Code Refactoring: All Java test files (*Test.java and IT*Test.java) have been refactored to use JUnit 5 annotations (@Test, @BeforeEach, @AfterAll, @BeforeAll) and assertion methods (org.junit.jupiter.api.Assertions.*), replacing their JUnit 4 counterparts.
• Mockito Integration Update: Mockito usage in tests has been updated to leverage MockitoExtension for JUnit 5, replacing the JUnit 4 MockitoJUnitRunner and its associated @Rule.
• Timeout Annotations: Integration tests now utilize JUnit 5's @Timeout annotation for setting test execution limits, replacing JUnit 4 Timeout rules.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly migrates a large number of tests from JUnit 4 to JUnit 5. The changes include updating dependencies in pom.xml files and modifying test classes to use JUnit 5 annotations and assertions. The migration is well-executed. I've added a few suggestions to further improve the tests by using more idiomatic JUnit 5 features, such as replacing try-catch-fail blocks with assertThrows for exception testing. This will make the tests more concise and readable.

[jinseopkim0]

nit: I believe this is redundant now, since we have a mandatory cleanup in finally.

[lqiu96]

Sounds good. I will resolve this in a follow up PR