docs: change the broken logo #1861
Conversation
shuoweil
requested review from
GarrettWu,
Genesis929,
chelsea-lin,
jialuoo,
shobsi,
sycai and
tswast
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
shuoweil
force-pushed
the
shuowei-github-logo
branch
from
c08d1c1 to
6b6e8bd
Compare
| " <td>\n", | ||
| " <a href=\"https://colab.research.google.com/github/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | ||
| " <img src=\"https://cloud.google.com/ml-engine/images/colab-logo-32px.png\" alt=\"Colab logo\"> Run in Colab\n", | ||
| " <img src=\"https://upload.wikimedia.org/wikipedia/commons/thumb/d/d0/Google_Colaboratory_SVG_Logo.svg/1600px-Google_Colaboratory_SVG_Logo.svg.png?20221103151432\" alt=\"Colab logo\" width=\"65\"> Run in Colab\n", |
There was a problem hiding this comment.
Please don't do this as the fix. If we must do something, at least upload to somewhere we control like our GitHub repository.
There was a problem hiding this comment.
According to GitHub's brand guidelines (https://github.com/logos), we are not permitted to store their logos in our repositories. While I couldn't find specific usage restrictions for the Google Colab logo, it's generally best practice to avoid storing third-party logos in our own codebase.
| " <td>\n", | ||
| " <a href=\"https://colab.research.google.com/github/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | ||
| " <img src=\"https://cloud.google.com/ml-engine/images/colab-logo-32px.png\" alt=\"Colab logo\"> Run in Colab\n", | ||
| " <img src=\"https://upload.wikimedia.org/wikipedia/commons/thumb/d/d0/Google_Colaboratory_SVG_Logo.svg/1600px-Google_Colaboratory_SVG_Logo.svg.png?20221103151432\" alt=\"Colab logo\" width=\"65\"> Run in Colab\n", |
There was a problem hiding this comment.
Looks like "?20221103151432" is redundant?
There was a problem hiding this comment.
Yes, I can remove the one at the end. It is how upload.wikimedia.org link setup, user may upload different version of the same logo, each of version can be specified using a timestamp. We can remove the timestamp, then it always render the latest version. We can either keep "?20221103151432" to ask for this specific version or removing it using the latest version. I believe it is better to remove the timestamp to always use the latest version of logo. I will remove all of timestamp.
|
I will use another approach to store logo in our git repo |
shuoweil
removed request for
GarrettWu,
Genesis929,
chelsea-lin,
jialuoo and
sycai
3 participants
docs: change the broken logo
b/427981044