-
Notifications
You must be signed in to change notification settings - Fork 63
docs: change the broken logo #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,12 +35,12 @@ | |
| "\n", | ||
| " <td>\n", | ||
| " <a href=\"https://colab.research.google.com/github/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | ||
| " <img src=\"https://cloud.google.com/ml-engine/images/colab-logo-32px.png\" alt=\"Colab logo\"> Run in Colab\n", | ||
| " <img src=\"https://upload.wikimedia.org/wikipedia/commons/thumb/d/d0/Google_Colaboratory_SVG_Logo.svg/1600px-Google_Colaboratory_SVG_Logo.svg.png?20221103151432\" alt=\"Colab logo\" width=\"65\"> Run in Colab\n", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like "?20221103151432" is redundant?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I can remove the one at the end. It is how upload.wikimedia.org link setup, user may upload different version of the same logo, each of version can be specified using a timestamp. We can remove the timestamp, then it always render the latest version. We can either keep "?20221103151432" to ask for this specific version or removing it using the latest version. I believe it is better to remove the timestamp to always use the latest version of logo. I will remove all of timestamp. |
||
| " </a>\n", | ||
| " </td>\n", | ||
| " <td>\n", | ||
| " <a href=\"https://github.com/googleapis/python-bigquery-dataframes/blob/main/notebooks/experimental/ai_operators.ipynb\">\n", | ||
| " <img src=\"https://cloud.google.com/ml-engine/images/github-logo-32px.png\" alt=\"GitHub logo\">\n", | ||
| " <img src=\"https://upload.wikimedia.org/wikipedia/commons/thumb/9/91/Octicons-mark-github.svg/1200px-Octicons-mark-github.svg.png?20180806170715\" alt=\"GitHub logo\" width=\"35\">\n", | ||
| " View on GitHub\n", | ||
| " </a>\n", | ||
| " </td>\n", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't do this as the fix. If we must do something, at least upload to somewhere we control like our GitHub repository.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to GitHub's brand guidelines (https://github.com/logos), we are not permitted to store their logos in our repositories. While I couldn't find specific usage restrictions for the Google Colab logo, it's generally best practice to avoid storing third-party logos in our own codebase.