refactor: add agg_ops.MinOp and MaxOp for sqlglot compiler #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_agg
branch
from
0776b87 to
17b5d3e
Compare
sycai
reviewed
Sep 18, 2025
bigframes/core/utils.py
Outdated
Comment on lines
251
to
253
| if isinstance(timedelta, int): | ||
| return timedelta | ||
|
|
Contributor
There was a problem hiding this comment.
Hmmmm, what's the reason behind this branch here? If the input is an integer, may be just leave it as-is at the call site?
Contributor
Author
There was a problem hiding this comment.
The compiler wants to support ir._literal(0, dtypes.TIMEDELTA_DTYPE). We have this change or undo this commit: 17b5d3e
Hence, let timedelta_to_micros to be generic when the time delta presented as an integer too. I think it would be ideal here.
chelsea-lin
force-pushed
the
main_chelsealin_agg
branch
from
17b5d3e to
2348896
Compare
sycai
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 445774480 🦕