build: Skip clirr check for protobuf 4.x upgrade #4061
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a temporary modification to the build configuration by skipping the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the clirr binary compatibility check for all modules by setting <clirr.skip>true</clirr.skip> in the parent POM. While this is likely intended to unblock a Protobuf 4.x upgrade, it introduces a significant risk by disabling a key quality gate for the entire project. My review includes a comment recommending a more targeted approach by ignoring specific breakages, or at least adding a TODO to track the re-enabling of this check to mitigate the risk of unintentionally releasing breaking changes.
| <!-- skipping clirr check for protobuf 4.x upgrade --> | ||
| <clirr.skip>true</clirr.skip> |
There was a problem hiding this comment.
Globally disabling the clirr check with <clirr.skip>true</clirr.skip> is a significant risk, as it prevents the detection of any unintended binary incompatibilities across all modules, not just those related to the protobuf upgrade. This could allow breaking changes to be released accidentally.
The preferred and safer approach in this repository is to add specific, expected breakages to the clirr-ignored-differences.xml files. Was this approach considered?
If globally disabling the check is the only option, it should be treated as a temporary measure. Please add a TODO comment with a link to a tracking issue to ensure the check is re-enabled promptly.
| <!-- skipping clirr check for protobuf 4.x upgrade --> | |
| <clirr.skip>true</clirr.skip> | |
| <!-- TODO(https://github.com/googleapis/sdk-platform-java/issues/XXXX): Re-enable clirr check. Temporarily skipping for protobuf 4.x upgrade. --> | |
| <clirr.skip>true</clirr.skip> |
diegomarquezp
left a comment
diegomarquezp
left a comment
There was a problem hiding this comment.
This probably needs the check skip on showcase, like we tried last time.
|
|
|
Looks like the workflow file uses clirr:check directly. This may be overriding sdk-platform-java/.github/workflows/ci.yaml Line 405 in 972f87a |
2 participants
The CLIRR check is failing due to protobuf 4.x upgrade in the RC versions. Skipping clirr check for protobuf 4.x upgrade in this and next cycle. We should re-enable them once protobuf 4.x upgrade is completed.