Skip to content

build: Skip clirr check for protobuf 4.x upgrade #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeli0 merged 2 commits into from
Jan 13, 2026
Merged

build: Skip clirr check for protobuf 4.x upgrade #4061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f0d1a5
build: Skip clirr check for protobuf 4.x upgrade
blakeli0 Jan 13, 2026
e598d36
Update pom.xml
blakeli0 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gapic-generator-java-pom-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
<junit.version>5.11.4</junit.version>
<mockito.version>4.11.0</mockito.version>
<slf4j.version>2.0.16</slf4j.version>
<!-- skipping clirr check for protobuf 4.x upgrade -->
<clirr.skip>true</clirr.skip>
Comment on lines +43 to +44
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Globally disabling the clirr check with <clirr.skip>true</clirr.skip> is a significant risk, as it prevents the detection of any unintended binary incompatibilities across all modules, not just those related to the protobuf upgrade. This could allow breaking changes to be released accidentally.

The preferred and safer approach in this repository is to add specific, expected breakages to the clirr-ignored-differences.xml files. Was this approach considered?

If globally disabling the check is the only option, it should be treated as a temporary measure. Please add a TODO comment with a link to a tracking issue to ensure the check is re-enabled promptly.

Suggested change
<!-- skipping clirr check for protobuf 4.x upgrade -->
<clirr.skip>true</clirr.skip>
<!-- TODO(https://github.com/googleapis/sdk-platform-java/issues/XXXX): Re-enable clirr check. Temporarily skipping for protobuf 4.x upgrade. -->
<clirr.skip>true</clirr.skip>

</properties>

<developers>
Expand Down Expand Up @@ -214,4 +216,4 @@
<url>https://repo1.maven.org/maven2</url>
</repository>
</repositories>
</project>
</project>
1 change: 1 addition & 0 deletions java-showcase/proto-gapic-showcase-v1beta1/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<properties>
<fmt.skip>true</fmt.skip>
<clirr.skip>true</clirr.skip>
</properties>

<dependencies>
Expand Down
Loading