build: Skip clirr check for downstream libraries #4062
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a build configuration adjustment to temporarily bypass the Clirr API compatibility check. This modification is specifically implemented to unblock and streamline the upgrade of Protobuf to version 4.x for dependent projects, preventing build failures that might arise from compatibility warnings during this transition. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the clirr binary compatibility check for downstream libraries by setting <clirr.skip>true</clirr.skip> in sdk-platform-java-config/pom.xml. While this is intended to facilitate a protobuf 4.x upgrade, it introduces a significant risk of releasing binary-incompatible changes. My review includes a suggestion to mark this as a temporary change with a TODO and a tracking issue to ensure the check is re-enabled in the future.
| <!-- skipping clirr check for protobuf 4.x upgrade for downstream libraries --> | ||
| <clirr.skip>true</clirr.skip> |
There was a problem hiding this comment.
Disabling the clirr check across all downstream libraries introduces a significant risk of shipping binary-incompatible changes. While this is noted as being for a protobuf upgrade, it's crucial to treat this as a temporary measure.
To ensure this check is re-enabled, please make the comment a TODO with a link to a tracking issue. This will make it easier to track and address later.
| <!-- skipping clirr check for protobuf 4.x upgrade for downstream libraries --> | |
| <clirr.skip>true</clirr.skip> | |
| <!-- TODO(issue-link): Re-enable clirr check. Temporarily skipping for protobuf 4.x upgrade. --> | |
| <clirr.skip>true</clirr.skip> |
|
|
3 participants
The downstream libraries' clirr check are failing due to protobuf rc release. For example, java-bigtable. Skipping clirr check in sdk-platform-java-config so we don't have to skip it for each downstream library. We should re-enable them after protobuf upgrade is completed.