Skip to content

build: Skip clirr check for downstream libraries #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 3 commits into from
Jan 13, 2026
Merged

build: Skip clirr check for downstream libraries #4062

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28dd91
build: skip clirr check for downstream libraries
blakeli0 Jan 13, 2026
170dc5c
Merge branch 'main' into skip-clirr-main
blakeli0 Jan 13, 2026
63bc155
Merge branch 'main' into skip-clirr-main
diegomarquezp Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk-platform-java-config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,7 @@

<properties>
<google-cloud-shared-dependencies.version>3.55.1-SNAPSHOT</google-cloud-shared-dependencies.version> <!-- {x-version-update:google-cloud-shared-dependencies:current} -->
<!-- skipping clirr check for protobuf 4.x upgrade for downstream libraries -->
<clirr.skip>true</clirr.skip>
Comment on lines +21 to +22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling the clirr check across all downstream libraries introduces a significant risk of shipping binary-incompatible changes. While this is noted as being for a protobuf upgrade, it's crucial to treat this as a temporary measure.

To ensure this check is re-enabled, please make the comment a TODO with a link to a tracking issue. This will make it easier to track and address later.

Suggested change
<!-- skipping clirr check for protobuf 4.x upgrade for downstream libraries -->
<clirr.skip>true</clirr.skip>
<!-- TODO(issue-link): Re-enable clirr check. Temporarily skipping for protobuf 4.x upgrade. -->
<clirr.skip>true</clirr.skip>

</properties>
</project>
Loading