tests: Use fixed copyright year in hermetic build integration tests #4065
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to ensure consistency in copyright years within hermetic build integration tests by explicitly setting a fixed year. It also updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator-java version and adds a new environment variable to fix the copyright year in hermetic build integration tests. My feedback focuses on improving maintainability by avoiding duplicated version strings and enhancing the clarity of a comment regarding the new environment variable.
| mvn dependency:copy \ | ||
| -B -ntp \ | ||
| -Dartifact=com.google.api:gapic-generator-java:2.63.0 \ | ||
| -Dartifact=com.google.api:gapic-generator-java:2.65.1 \ |
There was a problem hiding this comment.
The version 2.65.1 is hardcoded here and again on line 74. To improve maintainability and prevent inconsistencies when updating the version in the future, consider defining it as a variable at the beginning of this script block and reusing it. For example: GENERATOR_VERSION=2.65.1 and then use ${GENERATOR_VERSION} in both places.
| ] | ||
| env: | ||
| - "DOCKER_BUILDKIT=1" | ||
| # This does not work until gapic-generator-java is updated to the next released version. |
There was a problem hiding this comment.
This comment is a bit ambiguous. For better clarity, consider rephrasing it to explicitly state that this is a preparatory change for a future version of gapic-generator-java. This will help others understand why the variable is present but currently inactive.
# This env var will be used by a future gapic-generator-java version to fix the copyright year.
|
|
1 participant
No description provided.