Skip to content

tests: Use fixed copyright year in hermetic build integration tests #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blakeli0 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

tests: Use fixed copyright year in hermetic build integration tests #4065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .cloudbuild/library_generation/cloudbuild-library-generation-integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ steps:
- |
mvn dependency:copy \
-B -ntp \
-Dartifact=com.google.api:gapic-generator-java:2.63.0 \
-Dartifact=com.google.api:gapic-generator-java:2.65.1 \
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version 2.65.1 is hardcoded here and again on line 74. To improve maintainability and prevent inconsistencies when updating the version in the future, consider defining it as a variable at the beginning of this script block and reusing it. For example: GENERATOR_VERSION=2.65.1 and then use ${GENERATOR_VERSION} in both places.

-DoutputDirectory=/workspace
cd /workspace
mv gapic-generator-java-2.63.0.jar gapic-generator-java.jar
mv gapic-generator-java-2.65.1.jar gapic-generator-java.jar
id: prepare-generator-jar
waitFor: [ "-" ]

Expand All @@ -91,6 +91,8 @@ steps:
]
env:
- "DOCKER_BUILDKIT=1"
# This does not work until gapic-generator-java is updated to the next released version.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment is a bit ambiguous. For better clarity, consider rephrasing it to explicitly state that this is a preparatory change for a future version of gapic-generator-java. This will help others understand why the variable is present but currently inactive.

  # This env var will be used by a future gapic-generator-java version to fix the copyright year.

- "TEST_CURRENT_YEAR=2025"
id: generate-libraries
waitFor: [
"build-image",
Expand Down
Loading