Skip to content

Axis range for non-numeric vars #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantmcdermott merged 3 commits into from
Nov 20, 2025
+10 −6
Merged

Axis range for non-numeric vars #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b38677e
coerce axis vars to numeric for range (test)
grantmcdermott Nov 19, 2025
cb6c156
redundant to calculate limits for added layers
grantmcdermott Nov 19, 2025
6a6d1bd
news
grantmcdermott Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ where the formatting is also better._
the functions called rather than just their names. (#504 @zeileis)
- Legend labels are now correct if `by` is logical. Thanks to @TCornulier for
the report. (#512 @grantmcdermott)
- Axis limits are now correctly calculated for factor (and character) variables,
by coercing to numeric first. We also avoid the redundancy of re-calculating
axis limits for secondary plot layers. (#513 @grantmcdermott)

### Documentation

Expand Down
8 changes: 4 additions & 4 deletions R/lim.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ lim_args = function(settings) {
}

if (is.null(xlim)) {
xlim = range(c(
xlim = range(as.numeric(c(
datapoints[["x"]], datapoints[["xmin"]],
datapoints[["xmax"]]), finite = TRUE)
datapoints[["xmax"]])), finite = TRUE)
}
if (is.null(ylim)) {
ylim = range(c(
ylim = range(as.numeric(c(
datapoints[["y"]], datapoints[["ymin"]],
datapoints[["ymax"]]), finite = TRUE)
datapoints[["ymax"]])), finite = TRUE)
}

if (identical(type, "boxplot")) {
Expand Down
5 changes: 3 additions & 2 deletions R/tinyplot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,8 +882,9 @@ tinyplot.default = function(
#

# do this after computing yaxb because limits will depend on the previous calculations
lim_args(settings)

if (!add) {
lim_args(settings)
}

#
## facets: count -----
Expand Down