Skip to content

Conversation

@aspiers
Copy link
Contributor

@aspiers aspiers commented Jan 14, 2026

Summary by CodeRabbit

  • Chores

    • Added an extra type-check step to PR CI and updated the release script to run the new check.
    • Added configuration allowing specific pnpm command patterns for tooling execution.
    • Added a changeset noting a patch release.
  • New Features

    • Organization creation now accepts an optional handlePrefix field.
  • Tests

    • Updated tests to cover the handlePrefix behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 14, 2026 12:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

🦋 Changeset detected

Latest commit: e339b78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/sdk-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

Adds a pnpm typecheck step to PR checks; changes release script to run turbo check; adds CLI/agent bash permission config files; and updates the organizations hook and its tests to use handlePrefix when creating organizations.

Changes

Cohort / File(s) Summary
CI workflow
\.github/workflows/pr-check.yml
Inserts a pnpm typecheck step into the build-and-test job (after lint, before format:check).
Release script
package.json
Replaces the release command from turbo build && changeset publish to turbo check && changeset publish.
CLI / agent permissions
\.claude/settings.json, opencode.json
Adds configuration that allows specific pnpm bash subcommands (build*, check*, format*, lint*, test*, typecheck*).
SDK hook & tests
packages/sdk-react/src/hooks/useOrganizations.ts, packages/sdk-react/tests/hooks/useOrganizations.test.tsx
create payload now uses handlePrefix instead of handle; tests updated accordingly. Review call sites for the changed parameter name.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I hopped through CI, nose twitching with glee,
A typecheck step now guards each PR tree.
Turbo says "check" where "build" used to be,
Handles turned to prefixes — tidy and free.
🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding typecheck steps to both PR and release workflows (.github/workflows/pr-check.yml and package.json release script).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a5a2ee and e339b78.

📒 Files selected for processing (5)
  • .changeset/five-seas-do.md
  • .claude/settings.json
  • opencode.json
  • packages/sdk-react/src/hooks/useOrganizations.ts
  • packages/sdk-react/tests/hooks/useOrganizations.test.tsx
✅ Files skipped from review due to trivial changes (1)
  • opencode.json
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/sdk-react/src/hooks/useOrganizations.ts
  • .claude/settings.json
  • packages/sdk-react/tests/hooks/useOrganizations.test.tsx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-06T17:56:38.894Z
Learnt from: CR
Repo: hypercerts-org/hypercerts-sdk PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-06T17:56:38.894Z
Learning: Applies to packages/sdk-react/src/hooks/use*.ts : React hooks should use camelCase with use prefix (e.g., useAuth, useProfile)

Applied to files:

  • .changeset/five-seas-do.md
🔇 Additional comments (1)
.changeset/five-seas-do.md (1)

1-5: LGTM! Well-documented changeset.

The changeset properly documents the type error fix with appropriate semantic versioning (patch) and a clear description. The fix aligns with the PR objectives of adding typechecks to CI workflows, which likely surfaced this type error.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds type checking to the CI/CD pipelines to catch type errors before merging and releasing.

Changes:

  • Added explicit pnpm typecheck step to PR check workflow
  • Updated release script to use turbo check instead of turbo build, ensuring comprehensive validation (including typecheck) before publishing

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
package.json Modified release script to run full validation suite (turbo check) instead of just building
.github/workflows/pr-check.yml Added typecheck step to PR validation workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aspiers aspiers merged commit 3a346c4 into hypercerts-org:develop Jan 14, 2026
2 of 3 checks passed
@aspiers aspiers deleted the fix/typechecks branch January 14, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant