Skip to content

Conversation

@lguerard
Copy link
Contributor

Should fix #128

* Added input validation for 'dimension' and 'selection' parameters.
* Raises ValueError for invalid inputs with descriptive messages.
@lguerard lguerard changed the title Fix/128 processing settings Validate processing settings Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25%. Comparing base (ce66eef) to head (925c81d).
⚠️ Report is 64 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/bdv.py 71% 2 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           devel   #132   +/-   ##
====================================
- Coverage     25%    25%   -0%     
====================================
  Files         25     25           
  Lines       1711   1755   +44     
====================================
+ Hits         421    430    +9     
- Misses      1290   1325   +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu ehrenfeu changed the base branch from master to devel January 19, 2026 12:49
@ehrenfeu ehrenfeu self-requested a review January 19, 2026 12:49
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 19, 2026
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 19, 2026
Mostly done to help the static code analysis (Pylance) to understand
this is not a "reportPossiblyUnboundVariable" case.
@ehrenfeu ehrenfeu added the conventions Issue with formatting / naming / ... label Jan 19, 2026
@ehrenfeu ehrenfeu merged commit e6421c8 into imcf:devel Jan 19, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Jan 19, 2026
@lguerard lguerard deleted the fix/128_processing_settings branch January 22, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conventions Issue with formatting / naming / ...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Incomplete conditional path in get_processing_settings

2 participants