Skip to content

Validate processing settings #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehrenfeu merged 2 commits into from
Jan 19, 2026
Merged

Validate processing settings #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da5f514
feat(processing): validate inputs for get_processing_settings
lguerard Jan 19, 2026
925c81d
Initialize variables
ehrenfeu Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/imcflibs/imagej/bdv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from .. import pathtools
from ..log import LOG as log


# internal template strings used in string formatting (note: the `"""@private"""`
# pseudo-decorator is there to instruct [pdoc] to omit those variables when generating
# API documentation):
Expand Down Expand Up @@ -732,6 +731,22 @@ def get_processing_settings(dimension, selection, value, range_end):
tuple of str
processing_option, dimension_select
"""
processing_option = dimension_select = ""

# Validate inputs according to the function docstring
valid_dimensions = ("angle", "channel", "illumination", "tile", "timepoint")
if dimension not in valid_dimensions:
raise ValueError(
"Invalid dimension '%s', expected one of: %s"
% (dimension, ", ".join(valid_dimensions))
)

valid_selections = ("single", "multiple", "range")
if selection not in valid_selections:
raise ValueError(
"Invalid selection '%s', expected one of: %s"
% (selection, ", ".join(valid_selections))
)

if selection == "single":
processing_option = SINGLE % dimension
Expand Down
Loading