Skip to content

fix missing xlsx brief sheet #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 3 commits into from
Dec 11, 2025
Merged

fix missing xlsx brief sheet #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0214cc
fix missing xlsx brief sheet
harp-intel Dec 11, 2025
d9c9743
Update internal/common/common.go
harp-intel Dec 11, 2025
8b3b85c
Merge branch 'main' into xlsxbrief
harp-intel Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/report/report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ func runCmd(cmd *cobra.Command, args []string) error {
SummaryTableName: benchmarkSummaryTableName,
SummaryBeforeTableName: SpeedBenchmarkTableName,
InsightsFunc: insightsFunc,
SystemSummaryTableName: SystemSummaryTableName,
}

report.RegisterHTMLRenderer(DIMMTableName, dimmTableHTMLRenderer)
Expand Down
5 changes: 3 additions & 2 deletions internal/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ type ReportingCommand struct {
Tables []table.TableDefinition
ScriptParams map[string]string
SummaryFunc SummaryFunc
SummaryTableName string
SummaryTableName string // e.g., the benchmark or telemetry summary table
SummaryBeforeTableName string // the name of the table that the summary table should be placed before in the report
InsightsFunc InsightsFunc
AdhocFunc AdhocFunc
SystemSummaryTableName string // Optional: Only affects xlsx format reports. If set, the table with this name will be used as the "Brief" sheet in the xlsx report. If empty or unset, no "Brief" sheet is generated.
}

// Run is the common flow/logic for all reporting commands, i.e., 'report', 'telemetry', 'flame', 'lock'
Expand Down Expand Up @@ -405,7 +406,7 @@ func (rc *ReportingCommand) createReports(appContext AppContext, orderedTargetSc
})
// create the report(s)
for _, format := range formats {
reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SummaryTableName)
reportBytes, err := report.Create(format, allTableValues, targetScriptOutputs.TargetName, rc.SystemSummaryTableName)
if err != nil {
err = fmt.Errorf("failed to create report: %w", err)
return nil, err
Expand Down