fix missing xlsx brief sheet #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing "Brief" sheet in xlsx reports by properly configuring the system summary table name. The change introduces a new field to distinguish between benchmark/telemetry summaries and the system-wide summary used for xlsx brief sheets.
Key changes:
- Added
SystemSummaryTableNamefield to separate system summary from benchmark/telemetry summary tables - Updated report creation to use
SystemSummaryTableNamefor generating the Brief sheet in xlsx format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/common/common.go | Added SystemSummaryTableName field to ReportingCommand struct and updated report creation logic to use it |
| cmd/report/report.go | Initialized the new SystemSummaryTableName field in the report command configuration |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration option for report generation, specifically to allow specifying a "System Summary" table for reports. The changes primarily add support for this new table name and update the report creation logic to use it.
Reporting configuration enhancements:
SystemSummaryTableNamefield to theReportingCommandstruct to allow specifying a system summary table, which is used for generating a "Brief" sheet in xlsx reports.ReportingCommandinreport.goto set the newSystemSummaryTableNamefield.Report generation logic:
createReportsto useSystemSummaryTableNameinstead ofSummaryTableNamewhen generating reports, ensuring the correct summary table is included.