Skip to content

Conversation

@harp-intel
Copy link
Contributor

This pull request primarily focuses on improving logging verbosity and minor data handling in the flame graph rendering and script support checks. The most notable changes include reducing log levels for unsupported features to avoid cluttering logs, and making a small fix to whitespace handling when extracting maximum depth information.

Logging improvements:

  • Changed several log statements from Info to Debug level in internal/common/targets.go to reduce noise when scripts or tables are not supported for a given target, architecture, vendor, or microarchitecture. [1] [2] [3] [4]

Data handling fix:

  • Trimmed whitespace from the "maximum depth" section in maxRenderDepthFromOutput to ensure consistent output.
  • Removed redundant whitespace trimming in renderFlameGraph since the value is now already trimmed, preventing double processing.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel requested a review from Copilot December 11, 2025 15:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reduces logging noise and improves data consistency in the flame graph rendering pipeline. The main focus is making unsupported feature checks less verbose while ensuring whitespace is handled consistently.

Key Changes:

  • Reduced log verbosity for unsupported scripts and tables from Info to Debug level to prevent cluttering logs with expected conditions
  • Consolidated whitespace trimming for maximum depth value to a single location to avoid redundant processing

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
internal/common/targets.go Changed three log statements from Info to Debug when scripts are not supported for specific architectures, vendors, or microarchitectures
internal/common/common.go Changed log statement from Info to Debug when a table is not supported for a target
cmd/flame/flame_tables.go Added whitespace trimming when extracting maximum depth from script output
cmd/flame/render_html_flamegraph.go Removed redundant whitespace trimming now that the value is pre-trimmed upstream

@harp-intel harp-intel merged commit 54bf3cd into main Dec 11, 2025
4 of 5 checks passed
@harp-intel harp-intel deleted the fixups branch December 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants