Skip to content

Log and data cleanup #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 2 commits into from
Dec 11, 2025
Merged

Log and data cleanup #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
010c22f
clean maxdepth
harp-intel Dec 11, 2025
8eea1d1
clean logs
harp-intel Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/flame/flame_tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func maxRenderDepthFromOutput(outputs map[string]script.ScriptOutput) string {
}
for header, content := range sections {
if header == "maximum depth" {
return content
return strings.TrimSpace(content)
}
}
return ""
Expand Down
2 changes: 1 addition & 1 deletion cmd/flame/render_html_flamegraph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func renderFlameGraph(header string, tableValues table.TableValues, field string
return
}
maxDepth := tableValues.Fields[maxDepthFieldIndex].Values[0]
maxStackDepth, err := strconv.Atoi(strings.TrimSpace(maxDepth))
maxStackDepth, err := strconv.Atoi(maxDepth)
if err != nil {
slog.Error("failed to convert maximum stack depth", slog.String("error", err.Error()))
return
Expand Down
2 changes: 1 addition & 1 deletion internal/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ func outputsFromTargets(cmd *cobra.Command, myTargets []target.Target, tables []
targetScriptNames[targetIdx] = util.UniqueAppend(targetScriptNames[targetIdx], scriptName)
}
} else {
slog.Info("table not supported for target", slog.String("table", tbl.Name), slog.String("target", target.GetName()))
slog.Debug("table not supported for target", slog.String("table", tbl.Name), slog.String("target", target.GetName()))
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions internal/common/targets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition,
return false, err
}
if !slices.Contains(scriptDef.Architectures, arch) {
slog.Info("script not supported on target architecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("architecture", arch))
slog.Debug("script not supported on target architecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("architecture", arch))
return false, nil
}
}
Expand All @@ -768,7 +768,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition,
return false, err
}
if !slices.Contains(scriptDef.Vendors, vendor) {
slog.Info("script not supported on target CPU vendor", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("vendor", vendor))
slog.Debug("script not supported on target CPU vendor", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("vendor", vendor))
return false, nil
}
}
Expand All @@ -781,7 +781,7 @@ func ScriptSupportedOnTarget(t target.Target, scriptDef script.ScriptDefinition,
shortUarch = strings.Split(shortUarch, "-")[0] // handle GNR-D
shortUarch = strings.Split(shortUarch, " ")[0] // handle Turin (Zen 5)
if !slices.Contains(scriptDef.MicroArchitectures, uarch) && !slices.Contains(scriptDef.MicroArchitectures, shortUarch) {
slog.Info("script not supported on target CPU microarchitecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("microarchitecture", uarch))
slog.Debug("script not supported on target CPU microarchitecture", slog.String("script", scriptDef.Name), slog.String("target", t.GetName()), slog.String("microarchitecture", uarch))
return false, nil
}
}
Expand Down
Loading