Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates IPC Toolkit’s default broad-phase collision detection implementation to use LBVH (as introduced in #188) and aligns the getting-started tutorial text with the new default.
Changes:
- Switch
make_default_broad_phase()to constructLBVHinstead ofHashGrid. - Update the getting-started tutorial to state that the default broad phase is now
LBVH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ipc/broad_phase/default_broad_phase.hpp |
Changes the default broad-phase factory to return LBVH. |
docs/source/tutorials/getting_started.rst |
Updates the tutorial’s broad-phase list to reflect LBVH as the default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 96.96% 96.97%
=======================================
Files 161 161
Lines 24747 24747
Branches 893 894 +1
=======================================
+ Hits 23997 23998 +1
+ Misses 750 749 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace has_*() checks with bvh.size() <= 1 so functions require at least two primitives for collision tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the default broad phase to
LBVH.As shown in #188, the LBVH outperforms all other methods on a variety of scenes.
Type of change
Please delete options that are not relevant.