e2e: empty line generated at top of dependency KUTTL test #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency/00-create-resources-missing-deps.yaml when using scaffolding tool to create a controller with -optional-create-dependency, but without -required-create-dependency. Why Fix it: Should want to fix the template because this will generate an obscure warning when running the kuttl tests. What Fixed it: Replaced left trim with a right trim at the end of requiredCreateDependencies loop and the beginning of the next loop OptionalCreateDependencies. Signed-off-by: Daniel Lawton <dlawton@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when using scaffolding tool to create a controller with
-optional-create-dependency, but without-required-create-dependency, an empty line would appear at the top of the step 00-create-resources-missing-deps.yaml, check it out here .As shown in #580 the empty line needs to be removed to fix kuttl warnings.