Skip to content

e2e: empty line generated at top of dependency KUTTL test #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandre merged 1 commit into from
Jan 14, 2026
Merged

e2e: empty line generated at top of dependency KUTTL test #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cmd/scaffold-controller/data/tests/dependency/00-create-resources-missing-deps.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
name: {{ $packageName }}-dependency
spec:
cloudCredentialsRef:
# TODO(scaffolding): Use openstack-admin if the resouce needs admin credentials to be created
# TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
Copy link
Collaborator

@mandre mandre Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I noticed this typo is present in more files. I have another PR in preparation for fixes to the scaffolding tool, I'll fix the rest in my PR.

cloudName: openstack
secretName: openstack-clouds
managementPolicy: managed
Expand All @@ -25,7 +25,7 @@ metadata:
name: {{ $packageName }}-dependency-no-{{ . | lower }}
spec:
cloudCredentialsRef:
# TODO(scaffolding): Use openstack-admin if the resouce needs admin credentials to be created
# TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
cloudName: openstack
secretName: openstack-clouds
managementPolicy: managed
Expand All @@ -37,17 +37,17 @@ spec:
{{ . | camelCase }}Ref: {{ $packageName }}-dependency
{{- end }}
# TODO(scaffolding): Add the necessary fields to create the resource
{{- end }}
{{- end }}
{{- range .OptionalCreateDependencies }}
{{ end -}}
{{ end -}}
{{ range .OptionalCreateDependencies -}}
---
apiVersion: openstack.k-orc.cloud/v1alpha1
kind: {{ $kind }}
metadata:
name: {{ $packageName }}-dependency-no-{{ . | lower }}
spec:
cloudCredentialsRef:
# TODO(scaffolding): Use openstack-admin if the resouce needs admin credentials to be created
# TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
cloudName: openstack
secretName: openstack-clouds
managementPolicy: managed
Expand All @@ -65,7 +65,7 @@ metadata:
name: {{ .PackageName }}-dependency-no-secret
spec:
cloudCredentialsRef:
# TODO(scaffolding): Use openstack-admin if the resouce needs admin credentials to be created
# TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
cloudName: openstack
secretName: {{ .PackageName }}-dependency
managementPolicy: managed
Expand Down