Skip to content

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jan 12, 2026

Changes

  • 🐛 Failure to detect middleware in not an error now, just a warning.

Log a warning if middleware version retrieval fails and set it to '<unknown>'.
@matejvasek matejvasek requested a review from creydr January 12, 2026 21:12
@knative-prow
Copy link

knative-prow bot commented Jan 12, 2026

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Log a warning if middleware version retrieval fails and set it to ''.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.13%. Comparing base (b8ab823) to head (5d1d252).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   55.12%   55.13%   +0.01%     
==========================================
  Files         170      170              
  Lines       19965    19965              
==========================================
+ Hits        11005    11008       +3     
+ Misses       7882     7880       -2     
+ Partials     1078     1077       -1     
Flag Coverage Δ
e2e 39.39% <ø> (ø)
e2e go 35.44% <ø> (?)
e2e node 30.99% <ø> (ø)
e2e python 35.09% <ø> (ø)
e2e quarkus 31.14% <ø> (?)
e2e rust 30.60% <ø> (?)
e2e springboot 30.63% <ø> (+0.07%) ⬆️
e2e typescript 31.10% <ø> (ø)
integration 17.47% <ø> (+0.01%) ⬆️
unit macos-14 45.10% <ø> (ø)
unit macos-latest 45.10% <ø> (ø)
unit ubuntu-24.04-arm 45.20% <ø> (ø)
unit ubuntu-latest 46.00% <ø> (ø)
unit windows-latest 45.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for dsimansk and jrangelramos January 12, 2026 21:33
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@knative-prow knative-prow bot merged commit a5af75e into main Jan 13, 2026
48 checks passed
@matejvasek matejvasek mentioned this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants