Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jan 31, 2025

Important

Introduces public_api_client in Langfuse class for public API access, maintaining self.client for backward compatibility.

  • Behavior:
    • Introduces public_api_client in Langfuse class for public API access.
    • Sets self.api to public_api_client for new API interactions.
    • Retains self.client as alias for public_api_client for backward compatibility, to be removed in next major release.

This description was created by Ellipsis for 45701b2. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Introduces changes to the Langfuse Python client to improve API client naming and accessibility while maintaining backward compatibility.

  • Renamed client attribute to public_api_client in langfuse/client.py for better clarity
  • Added new api attribute pointing to same client instance for modern usage
  • Marked legacy client attribute for deprecation in next major release

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 9497560 into main Feb 5, 2025
10 checks passed
@hassiebp hassiebp deleted the feat-add-api branch February 5, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants