-
Notifications
You must be signed in to change notification settings - Fork 227
feat(scores): add session and dataset run scores #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
78 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR adds support for session and dataset run scores in the Langfuse Python SDK, updates sampling logic, and introduces new organization and SCIM-related endpoints.
BaseScoreand related classes by makingtrace_idoptional and addingsession_id,dataset_run_id, andmetadata.ScoreV2Clientwith updated methods for handling different score types.LangfuseResourceManager._add_score_taskto ensure session/dataset run scores are not sampled out.metrics.daily()withmetrics.metrics()endpoint supporting custom queries.This description was created by
for b356fc0. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR adds support for session and dataset run scores in the Langfuse Python SDK, allowing scores to be associated with sessions and dataset runs in addition to traces.
BaseScoreand related classes to maketrace_idoptional and add new fieldssession_id,dataset_run_id, andmetadatain/langfuse/api/resources/commons/types/base_score.pyScoreV2Clientin/langfuse/api/resources/score_v_2/client.pywith updated methods for handling different score typesLangfuseResourceManager._add_score_taskto ensure session/dataset run scores are not sampled outmetrics.daily()with more flexiblemetrics.metrics()endpoint supporting custom queries