fix(client): do not escape url param with httpx > 0.28 #1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix URL parameter encoding in
client.pyfor compatibility withhttpxversion 0.28+ by modifying_url_encodefunction._url_encodeinclient.pyto skip re-quoting URL parameters ifhttpxversion is 0.28 or higher.is_url_paramargument to_url_encodeto control this behavior.httpxversion 0.28+ by checkinghttpx.__version__.Versionfrompackaging.versioninclient.py.This description was created by
for 871bf29. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixed URL parameter encoding compatibility issue with httpx >0.28 in the Python SDK to prevent double-encoding of URL parameters.
_url_encodemethod inlangfuse/_client/client.pyto avoid double URL encoding, as httpx >0.28 now handles WHATWG-compliant encoding internally