Skip to content

fix(client): do not escape url param with httpx > 0.28 #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 1 commit into from
Jul 2, 2025
Merged

fix(client): do not escape url param with httpx > 0.28 #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions langfuse/_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
_AgnosticContextManager,
_agnosticcontextmanager,
)
from packaging.version import Version

from langfuse._client.attributes import LangfuseOtelSpanAttributes
from langfuse._client.datasets import DatasetClient, DatasetItemClient
Expand Down Expand Up @@ -1709,7 +1710,7 @@ def get_dataset(

while True:
new_items = self.api.dataset_items.list(
dataset_name=self._url_encode(name),
dataset_name=self._url_encode(name, is_url_param=True),
page=page,
limit=fetch_items_page_size,
)
Expand Down Expand Up @@ -2261,7 +2262,14 @@ def update_prompt(

return updated_prompt

def _url_encode(self, url: str) -> str:
def _url_encode(self, url: str, *, is_url_param: Optional[bool] = False) -> str:
# httpx ≥ 0.28 does its own WHATWG-compliant quoting (eg. encodes bare
# “%”, “?”, “#”, “|”, … in query/path parts). Re-quoting here would
# double-encode, so we skip when the value is about to be sent straight
# to httpx (`is_url_param=True`) and the installed version is ≥ 0.28.
if is_url_param and Version(httpx.__version__) >= Version("0.28.0"):
return url

# urllib.parse.quote does not escape slashes "/" by default; we need to add safe="" to force escaping
# we need add safe="" to force escaping of slashes
# This is necessary for prompts in prompt folders
Expand Down