fix(openai): add check for metadata NotGiven #1240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes
metadatavalidation in_get_langfuse_data_from_kwargsto handleNotGiventype inlangfuse/openai.py.langfuse/openai.py,_get_langfuse_data_from_kwargsnow checks ifmetadatais an instance ofNotGivenbefore validating it as a dictionary.TypeErrorwhenmetadatais not provided inkwargs.This description was created by
for 0959b2b. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Improves OpenAI SDK compatibility by fixing metadata validation to handle NotGiven type, particularly important for OpenAI Agent SDK integration.
langfuse/openai.pyto properly handleNotGivensentinel value in metadata parameter validationNotGivenby OpenAI SDKNotGivenas a valid state