Skip to content

fix(openai): add check for metadata NotGiven #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Jul 4, 2025
Merged

fix(openai): add check for metadata NotGiven #1240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0959b2b
fix(openai): add check for metadata NotGiven
hassiebp Jul 4, 2025
5190866
Merge branch 'main' into fix-oai-agentsdk-metadata
hassiebp Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion langfuse/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,11 @@ def _get_langfuse_data_from_kwargs(resource: OpenAiDefinition, kwargs):
raise ValueError("parent_observation_id requires trace_id to be set")

metadata = kwargs.get("metadata", {})
if metadata is not None and not isinstance(metadata, dict):
if (
metadata is not None
and not isinstance(metadata, NotGiven)
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new check for NotGiven is good; consider adding an inline comment explaining why NotGiven is skipped in type validation.

Suggested change
and not isinstance(metadata, NotGiven)
and not isinstance(metadata, NotGiven) # NotGiven is a sentinel for missing values, not a dict

and not isinstance(metadata, dict)
):
raise TypeError("metadata must be a dictionary")

model = kwargs.get("model", None) or None
Expand Down