change README and llama-stack-client inference chat-completion to use chat.completions.create
#240
+65
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se chat.completions.create
mattf
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
reluctantfuturist,
vladimirivic and
yanxi0830
as code owners
ashwinb
requested changes
Jun 25, 2025
…g InferenceStreamPrintableEvent class, add type hints
ashwinb
approved these changes
Jun 25, 2025
Contributor
ashwinb
left a comment
ashwinb
left a comment
There was a problem hiding this comment.
cool this looks pretty good, thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates README to use chat.completions.create instead of inference.chat_completion
Test Plan
run examples in the README