chore(refactor): replace string-based resource registration with direct method calls #4314
+66
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mattf
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb and
raghotham
as code owners
leseb
reviewed
Dec 8, 2025
ashwinb
reviewed
Dec 10, 2025
| pass | ||
|
|
||
|
|
||
| RESOURCES = [ |
Contributor
There was a problem hiding this comment.
thank you! it was quite terrible
|
This pull request has merge conflicts that must be resolved before it can be merged. @mattf please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
leseb
approved these changes
Dec 15, 2025
Collaborator
leseb
left a comment
leseb
left a comment
There was a problem hiding this comment.
please resolve the conflicts
…ct method calls Remove RESOURCES list with string method names and replace with explicit typed calls for each resource type. Extract common registration logic into _register_resource helper with generic type parameters. - Add ListResourcesResponse[ResourceT] generic base class to resource.py - Update all list response types to inherit from generic base - Replace getattr-based method lookup with direct impl method calls - Add proper type hints using PEP 695 generics (InputT: BaseModel, ResourceT: Resource)
ashwinb
force-pushed
the
squash-clever-resource-registration
branch
from
664c1ac to
94de40a
Compare
ashwinb
force-pushed
the
squash-clever-resource-registration
branch
3 times, most recently
from
d919dc0 to
94de40a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove RESOURCES list with string method names and replace with explicit typed calls for each resource type. Extract common registration logic into _register_resource helper with generic type parameters.