Skip to content

[Android Auto] Fix incorrect coroutine scope #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmadsen merged 1 commit into from
Sep 27, 2022
Merged

[Android Auto] Fix incorrect coroutine scope #6398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...idauto/src/main/java/com/mapbox/androidauto/car/placeslistonmap/PlacesListOnMapManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ class PlacesListOnMapManager(
styleLoadedListener = null
MapboxNavigationApp.unregisterObserver(navigationObserver)
carMapSurface = null
coroutineScope?.cancel()
coroutineScope = null
}

private fun onAttached(mapboxNavigation: MapboxNavigation) {
Expand All @@ -99,8 +101,6 @@ class PlacesListOnMapManager(

private fun onDetached() {
placesListItemMapper = null
coroutineScope?.cancel()
coroutineScope = null
}

private fun loadPlaceRecords() {
Expand Down