[Android Auto] Fix incorrect coroutine scope #6398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Sep 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #6398 +/- ##
=========================================
Coverage 68.93% 68.93%
Complexity 4589 4589
=========================================
Files 695 695
Lines 27449 27449
Branches 3195 3195
=========================================
Hits 18921 18921
Misses 7287 7287
Partials 1241 1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Zayankovsky caught an issue here #6371 (comment)
Skipping the changelog because this bug is not released. It would also be difficult to reproduce at the moment.
I looked into adding tests to PlacesListOnMapManager, but that requires a lot of changes at the moment.