-
Notifications
You must be signed in to change notification settings - Fork 319
[Android Auto] Remove mapbox navigation from PlaceListOnMapScreen #6371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Auto] Remove mapbox navigation from PlaceListOnMapScreen #6371
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6371 +/- ##
============================================
+ Coverage 68.93% 68.94% +0.01%
+ Complexity 4589 4578 -11
============================================
Files 695 691 -4
Lines 27449 27376 -73
Branches 3195 3191 -4
============================================
- Hits 18921 18875 -46
+ Misses 7287 7262 -25
+ Partials 1241 1239 -2
|
9aef581 to
8c218a7
Compare
| PlacesListItemMapper( | ||
| PlaceMarkerRenderer(mainCarContext.carContext), | ||
| mainCarContext | ||
| .mapboxNavigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's this dependency that needs to be moved, getting the unit type to become observable is a bit complicated
libnavui-androidauto/api/current.txt
Outdated
|
|
||
| public final class CarLocationRenderer implements com.mapbox.maps.extension.androidauto.MapboxCarMapObserver { | ||
| ctor public CarLocationRenderer(com.mapbox.androidauto.car.MainCarContext mainCarContext); | ||
| method public void onAttached(com.mapbox.maps.extension.androidauto.MapboxCarMapSurface mapboxCarMapSurface); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation for this is here #6396
b8b545d to
594a48e
Compare
Description
There's a lot of refactoring in order to get this to work. I also reached a point where it is better to dig into
CarRouteRequestbecause that class is a little painful to use withMapboxNavigationin the constructorScreenshots or Gifs