Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Sep 22, 2022

Description

There's a lot of refactoring in order to get this to work. I also reached a point where it is better to dig into CarRouteRequest because that class is a little painful to use with MapboxNavigation in the constructor

Screenshots or Gifs

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #6371 (b8b545d) into main (c314b02) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b8b545d differs from pull request most recent head 594a48e. Consider uploading reports for the commit 594a48e to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6371      +/-   ##
============================================
+ Coverage     68.93%   68.94%   +0.01%     
+ Complexity     4589     4578      -11     
============================================
  Files           695      691       -4     
  Lines         27449    27376      -73     
  Branches       3195     3191       -4     
============================================
- Hits          18921    18875      -46     
+ Misses         7287     7262      -25     
+ Partials       1241     1239       -2     
Impacted Files Coverage Δ
...igation/dropin/internal/NavigationViewContextEx.kt 37.50% <0.00%> (-6.95%) ⬇️
...igation/dropin/internal/MapboxNavigationViewApi.kt 90.16% <0.00%> (-2.43%) ⬇️
.../mapbox/navigation/dropin/NavigationViewContext.kt 70.00% <0.00%> (-0.74%) ⬇️
...apbox/navigation/base/options/NavigationOptions.kt 98.02% <0.00%> (-0.10%) ⬇️
...ava/com/mapbox/navigation/dropin/NavigationView.kt 0.00% <0.00%> (ø)
.../com/mapbox/navigation/dropin/NavigationViewApi.kt 100.00% <0.00%> (ø)
...n/ui/app/internal/routefetch/RoutePreviewAction.kt 100.00% <0.00%> (ø)
...component/infopanel/RoutePreviewButtonComponent.kt 100.00% <0.00%> (ø)
...ponent/infopanel/StartNavigationButtonComponent.kt 100.00% <0.00%> (ø)
...mapbox/navigation/dropin/NavigationViewApiError.kt
... and 6 more

@kmadsen kmadsen force-pushed the km-remove-mapbox-navigation-PlaceListOnMapScreen branch from 9aef581 to 8c218a7 Compare September 26, 2022 22:40
@kmadsen kmadsen marked this pull request as ready for review September 26, 2022 22:44
@kmadsen kmadsen requested a review from a team as a code owner September 26, 2022 22:44
PlacesListItemMapper(
PlaceMarkerRenderer(mainCarContext.carContext),
mainCarContext
.mapboxNavigation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this dependency that needs to be moved, getting the unit type to become observable is a bit complicated


public final class CarLocationRenderer implements com.mapbox.maps.extension.androidauto.MapboxCarMapObserver {
ctor public CarLocationRenderer(com.mapbox.androidauto.car.MainCarContext mainCarContext);
method public void onAttached(com.mapbox.maps.extension.androidauto.MapboxCarMapSurface mapboxCarMapSurface);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation for this is here #6396

@kmadsen kmadsen enabled auto-merge (squash) September 26, 2022 23:52
@kmadsen kmadsen force-pushed the km-remove-mapbox-navigation-PlaceListOnMapScreen branch from b8b545d to 594a48e Compare September 27, 2022 18:31
@kmadsen kmadsen merged commit 7e142c2 into main Sep 27, 2022
@kmadsen kmadsen deleted the km-remove-mapbox-navigation-PlaceListOnMapScreen branch September 27, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants