fix(kqueue): fix syscall error propagation in completion handling#207
Open
jbuckmccready wants to merge 1 commit intomitchellh:mainfrom
Open
fix(kqueue): fix syscall error propagation in completion handling#207jbuckmccready wants to merge 1 commit intomitchellh:mainfrom
jbuckmccready wants to merge 1 commit intomitchellh:mainfrom
Conversation
Extract errno_to_result helper to consistently convert posix errno values to the negative i32 format expected by syscall_result, replacing ad-hoc inline conversions. Fix shutdown operation to properly convert errno on failure instead of passing raw syscall result, and add NOTCONN error handling for shutdown completions.
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was bug in how error values were propagated in kqueue backend, detected by seeing
PERMerror (1) on shutdown whenPERMis not documented to return from posix shutdown.Changes
Extract
errno_to_resulthelper to consistently convert posix errno values to the negative i32 format expected bysyscall_result, replacing ad-hoc inline conversions. Fix shutdown operation to properly convert errno on failure instead of passing raw syscall result, and addNOTCONNerror handling for shutdown completions.