Skip to content

Conversation

@kunalbabre
Copy link
Contributor

Description

  • Replace outdated 'Preferences: Open Settings (JSON)' instructions
  • Add proper guidance for 'MCP: Open User Configuration' command
  • Update JSON examples to remove mcp wrapper key
  • Clarify user vs workspace configuration methods
  • Fixes issue with outdated documentation across all servers

Affects: sequentialthinking, filesystem, memory, everything, git

Server Details

-- None

Motivation and Context

To fix VS Code installation instructions to use mcp.json as raised in #2320

How Has This Been Tested?

-- N/A: Verified manually

Breaking Changes

-- N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

- Replace outdated 'Preferences: Open Settings (JSON)' instructions
- Add proper guidance for 'MCP: Open User Configuration' command
- Update JSON examples to remove mcp wrapper key
- Clarify user vs workspace configuration methods
- Fixes issue with outdated documentation across all servers

Affects: sequentialthinking, filesystem, memory, everything, git
@luke396
Copy link

luke396 commented Jul 12, 2025

@kunalbabre Thanks for opening this PR!

I have two quick questions for the maintainers to weigh in on:

  1. Should we explicitly recommend one installation method, or simply describe the options and let users decide?
  2. Would it be helpful to include a link to the official VS Code documentation for further details?

These are just my personal thoughts—happy to defer to whatever the maintainers consider best.

- Add link to official VS Code MCP documentation in all server READMEs
- Enhances existing VS Code installation instructions with authoritative reference
- Provides users with comprehensive documentation for advanced configuration
- Complements the existing two-method approach with additional resources

Affects: everything, filesystem, git, memory, sequentialthinking
- Remove unnecessary explanatory note about JSON format
- JSON examples already demonstrate the correct format clearly
- Streamlines documentation to focus on essential information
- Maintains reference to official VS Code MCP documentation

The removed note was redundant since both configuration methods 
use identical JSON structure shown in the examples.
@kunalbabre
Copy link
Contributor Author

@luke396 - great points

  1. Should we explicitly recommend one installation method, or simply describe the options and let users decide? I think showing both and recommending one will be beneficial
  2. Would it be helpful to include a link to the official VS Code documentation for further details? Agreed, added.

@olaservo olaservo added the documentation Improvements or additions to documentation label Jul 18, 2025
Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@olaservo olaservo merged commit 1028b32 into modelcontextprotocol:main Aug 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants