Skip to content

Conversation

@olaservo
Copy link
Member

@olaservo olaservo commented Aug 4, 2025

@cliffhall
Copy link
Member

cliffhall commented Aug 4, 2025

@olaservo The Oracle entry points to a blog post, not a repo or documentation page. I've made a request on the original PR that the author update the link.

Also, the KirokuForms link points to a page with no real documentation on setup and use at all. I have also requested the author update to a repo or doc page with more complete usage guidance.

For now, we can remove both from this PR.

@benman1
Copy link

benman1 commented Aug 4, 2025

@olaservo @cliffhall No real documentation on setup and use:

Seriously, as I've commented on the original PR - if there's anything to improve, I am happy to learn.

@cliffhall
Copy link
Member

Seriously, as I've commented on the original PR - if there's anything to improve, I am happy to learn.

@benman1 Please change your PR to point to the second page, which actually contains information about setup and use of the MCP server, unless there is a more useful page that isn't specific to langchain.

The first page doesn't have any information other than that you need to put a bearer token in requests. Doesn't say where the endpoint is, doesn't say how to configure common clients for use with it. Doesn't list the available tools. I left an example on your PR, but you can view the landing pages of any of the above links to see what information is commonly presented.

@benman1
Copy link

benman1 commented Aug 4, 2025

@cliffhall a lot of the documentation is in the subpages, for example here https://www.kirokuforms.com/ai/mcp/tools/hitl, but I can appreciate that it's easier to read if it's all on one page. I can update the documentation and will update here.

@benman1
Copy link

benman1 commented Aug 5, 2025

Hi @cliffhall! Thank you so much for taking the time to provide the feedback, much appreciated! I've looked at the github example you provided and I've cleaned up the main MCP documentation page, added tools and resources, an overview of the different modes of form generation, and I've linked the documentation together a bit better so it should be easier to find documentation. Let me know if this is better, please!

@cliffhall
Copy link
Member

Hi @cliffhall! Thank you so much for taking the time to provide the feedback, much appreciated! I've looked at the github example you provided and I've cleaned up the main MCP documentation page, added tools and resources, an overview of the different modes of form generation, and I've linked the documentation together a bit better so it should be easier to find documentation. Let me know if this is better, please!

Way better now, thanks.

cliffhall
cliffhall previously approved these changes Aug 5, 2025
@cliffhall cliffhall dismissed their stale review August 5, 2025 17:35

Mistakenly approved when there was an outstanding problem with Oracle link

@olaservo
Copy link
Member Author

olaservo commented Aug 6, 2025

Hi @cliffhall , the Oracle link is updated now.

@olaservo olaservo requested a review from cliffhall August 6, 2025 02:19
@krisrice
Copy link
Contributor

krisrice commented Aug 6, 2025

Hi @cliffhall , the Oracle link is updated now.

Thanks! I came to do it and you already did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants