Skip to content

Conversation

@jpshack-at-palomar
Copy link
Contributor

@jpshack-at-palomar jpshack-at-palomar commented Mar 4, 2025

Add support for all pull request operations documented in README.md that were previously included in the MCP server implementation but omitted from the list of advertised functions. The bug here is that the index.ts doesn't list all of the tools that are present.

This includes:

  • get_pull_request: Get details of a specific pull request
  • list_pull_requests: List and filter repository pull requests
  • create_pull_request_review: Create a review on a pull request
  • merge_pull_request: Merge a pull request
  • get_pull_request_files: Get the list of files changed in a pull request
  • get_pull_request_status: Get the combined status of all status checks
  • update_pull_request_branch: Update a PR branch with latest base branch changes
  • get_pull_request_comments: Get the review comments on a pull request
  • get_pull_request_reviews: Get the reviews on a pull request

Description

Server Details

  • Server: github

Motivation and Context

Solves a frequently reported bug, namely that the GitHub MCP Server does not advertise its full capabilities due to an accidental omission in the original release. See bugs #541 and #493.

How Has This Been Tested?

This has been tested with an MCP client (cursor) and should work identically with all clients.

Breaking Changes

No breaking changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • [ N/A ] I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • [ N/A ] I have added appropriate error handling
  • [ N/A ] I have documented all environment variables and configuration options

Add support for all pull request operations documented in README.md that were
previously missing from the MCP server implementation. This includes:

- get_pull_request: Get details of a specific pull request
- list_pull_requests: List and filter repository pull requests
- create_pull_request_review: Create a review on a pull request
- merge_pull_request: Merge a pull request
- get_pull_request_files: Get the list of files changed in a pull request
- get_pull_request_status: Get the combined status of all status checks
- update_pull_request_branch: Update a PR branch with latest base branch changes
- get_pull_request_comments: Get the review comments on a pull request
- get_pull_request_reviews: Get the reviews on a pull request
@jpshack-at-palomar jpshack-at-palomar changed the title feat(github): Add missing pull request operations to MCP server bug(github): Add missing pull request operations to MCP server Mar 4, 2025
@jpshack-at-palomar
Copy link
Contributor Author

jpshack-at-palomar commented Mar 4, 2025

@dsp-ant Could I get a quick look at this one? Should be a straight forward review of a one file change fix for a bug that slipped through on the GitHub MCP server. Closes #493 and #541.

Copy link

@kushparikh01 kushparikh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking for this, can this get merged please!

@milesj-performio
Copy link

Also hoping this can be resolved quickly since it's quite straight forward. Thank you!

@jaymegordo
Copy link

Everyone and their dog is using MCP now how do we not have an executive order to get this merged??

@michael-airspace
Copy link

Looks like there's a lot of support for this change, and it seems straightforward. Merging this soon would really help keep things moving smoothly. Appreciate your help in getting this across the finish line!

@angiejones
Copy link

here to beg for a merge

@dsp-ant dsp-ant self-requested a review March 11, 2025 10:08
@dsp-ant dsp-ant merged commit e65ec2d into modelcontextprotocol:main Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants