Skip to content

Conversation

@Mansi-mParticle
Copy link
Collaborator

…rsion

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Suppressed unchecked cast and cast never succeeds warnings to resolve Kotlin compilation issues.
  • Addressed type mismatch between WeakReference<RoktEmbeddedView> and WeakReference<Widget> for compatibility with Kotlin

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app and executed test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

}

override fun onLoad() {
override fun onLoad() : Unit{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Unit used in other kits? I ask because cursor is telling me it is implicitly a Unit, but I assume it's failing a linting check, which is surprising if it is implicit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's not required for some reason it's giving lint error

}

override fun onLoad() {
override fun onLoad() : Unit{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
override fun onLoad() : Unit{
override fun onLoad() : Unit {

@Mansi-mParticle Mansi-mParticle merged commit db125d0 into development Apr 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants