Skip to content

fix: Kotlin lint error related to type casting for specific Kotlin ve… #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 2 commits into from
Apr 14, 2025
Merged

fix: Kotlin lint error related to type casting for specific Kotlin ve… #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53cf1c
fix: Kotlin lint error related to type casting for specific Kotlin ve…
Mansi-mParticle Apr 12, 2025
01dc70e
fix formatting issue
Mansi-mParticle Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/main/kotlin/com/mparticle/kits/RoktKit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
For more details, visit the official documentation:
https://docs.rokt.com/developers/integration-guides/android/how-to/adding-a-placement/
*/
@Suppress("UNCHECKED_CAST", "CAST_NEVER_SUCCEEDS")
override fun execute(
viewName: String,
attributes: Map<String, String>?,
Expand All @@ -131,17 +132,17 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
) {
// Converting the placeholders to a Map<String, WeakReference<Widget>> by filtering and casting each entry
val placeholders: Map<String, WeakReference<Widget>>? = placeHolders?.mapNotNull { entry ->
(entry.value as? WeakReference<Widget>)?.let {
entry.key to it
}
val weakRef = entry.value
val widget = weakRef.get() as? Widget // Safe cast to Widget
widget?.let { entry.key to weakRef as WeakReference<Widget> } // Only include if it's a Widget
}?.toMap()
onUnloadCallback = onUnload
onLoadCallback = onLoad
onShouldHideLoadingIndicatorCallback = onShouldHideLoadingIndicator
onShouldShowLoadingIndicatorCallback = onShouldShowLoadingIndicator
val finalAttributes: HashMap<String, String> = HashMap<String, String>()
filterUser?.userAttributes?.let { attributes ->
for ((key, value) in attributes) {
filterUser?.userAttributes?.let { userAttrs ->
for ((key, value) in userAttrs) {
finalAttributes[key] = value.toString()
}
}
Expand Down Expand Up @@ -183,19 +184,19 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
const val NO_APP_VERSION_FOUND = "No App version found, can't initialize kit."
}

override fun onLoad() {
override fun onLoad(): Unit {
onLoadCallback?.run()
}

override fun onShouldHideLoadingIndicator() {
override fun onShouldHideLoadingIndicator(): Unit {
onShouldHideLoadingIndicatorCallback?.run()
}

override fun onShouldShowLoadingIndicator() {
override fun onShouldShowLoadingIndicator(): Unit {
onShouldShowLoadingIndicatorCallback?.run()
}

override fun onUnload(reason: Rokt.UnloadReasons) {
override fun onUnload(reason: Rokt.UnloadReasons): Unit {
onUnloadCallback?.run()
}
}
Expand Down
Loading