Skip to content

Conversation

@jbampton
Copy link
Contributor

Not been updated for 3 years and possible security risk

refs mruby/mruby#6564

Not been updated for 3 years and possible security risk
@jbampton jbampton requested a review from matz as a code owner June 25, 2025 02:28
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the project's security posture and maintaining a healthy dependency tree by eliminating outdated and potentially risky pre-commit hooks. The change streamlines the development environment by removing unmaintained tooling configurations.

Highlights

  • Security & Maintenance: Removed pre-commit hooks sourced from the jumanjihouse/pre-commit-hooks repository. This action addresses potential security risks and reduces reliance on tools that have not been updated for three years, as indicated in the PR description.
  • Tooling Configuration: Specifically, the reek (Ruby code smell detector) and rubocop (Ruby static code analyzer and formatter) hooks, previously configured under the jumanjihouse repository in .pre-commit-config.yaml, have been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an outdated pre-commit hook repository, which is a good security practice. However, this also removes the rubocop and reek static analysis hooks for Ruby without providing a replacement. My review suggests adding modern, maintained alternatives for these hooks to ensure that code quality checks remain in place.

@bovi bovi merged commit 63c7080 into mruby:master Jun 25, 2025
3 checks passed
@jbampton jbampton deleted the remove-outdated-hooks branch June 25, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants