Skip to content

Uptake the changes to publish responses and add get_condition and get_measurement from id #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dixonjoel merged 7 commits into from
Nov 19, 2025
Merged

Uptake the changes to publish responses and add get_condition and get_measurement from id #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6095249
Upgrade to latest data.client dependency
Nov 18, 2025
2d4485d
Fix mypy errors
Nov 18, 2025
3fd4cc5
Fix nps style errors
Nov 18, 2025
2aaa260
Update examples for new API
Nov 18, 2025
c6c8045
Update all notebooks for the new datastore service API
Nov 18, 2025
34d46cd
Add unit test coverage for get_measurement and get_condition.
Nov 18, 2025
810d732
Remove call to get_measurement - not needed
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/notebooks/custom-metadata/custom_metadata.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
"\n",
"step = Step(name=\"Initial step\", test_result_id=test_result_id)\n",
"step_id = data_store_client.create_step(step)\n",
"published_measurement = data_store_client.publish_measurement(\n",
"data_store_client.publish_measurement(\n",
" name=\"scope reading\",\n",
" value=waveform,\n",
" step_id=step_id,\n",
Expand Down
7 changes: 3 additions & 4 deletions examples/notebooks/overview/publish_measurement.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,12 @@
")\n",
"step = Step(name=\"Initial step\", test_result_id=test_result_id)\n",
"step_id = data_store_client.create_step(step)\n",
"published_measurement = data_store_client.publish_measurement(\n",
"published_measurement_id = data_store_client.publish_measurement(\n",
" name=name,\n",
" value=waveform,\n",
" step_id=step_id,\n",
")\n",
"\n",
"print(f\"The published measurement id is {published_measurement.id}\")"
"print(f\"The published measurement id is {published_measurement_id}\")"
]
},
{
Expand All @@ -251,7 +250,7 @@
"source": [
"from nitypes.waveform import AnalogWaveform\n",
"\n",
"published_measurements = data_store_client.query_measurements(odata_query=f\"$filter=id eq {published_measurement.id}\")\n",
"published_measurements = data_store_client.query_measurements(odata_query=f\"$filter=id eq {published_measurement_id}\")\n",
"found_measurement = next(iter(published_measurements), None)\n",
"\n",
"if found_measurement is not None:\n",
Expand Down
40 changes: 20 additions & 20 deletions examples/overview/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions examples/overview/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ requires-poetry = '>=2.1,<3.0'
[tool.poetry.dependencies]
python = "^3.10"
protobuf = {version=">=4.21"}
ni-datamonikers-v1-client = { version = ">=0.1.0.dev1", allow-prereleases = true }
ni-measurements-data-v1-client = { version = ">=0.2.0.dev2", allow-prereleases = true }
ni-measurements-metadata-v1-client = { version = ">=0.2.0.dev2", allow-prereleases = true }
ni-protobuf-types = { version = ">=1.0.1.dev0", allow-prereleases = true }
hightime = { version = ">=0.3.0.dev0", allow-prereleases = true }
grpcio-tools = [
Expand Down
5 changes: 3 additions & 2 deletions examples/overview/src/overview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,17 @@ def publish_data() -> str:
# Publish the test step with the waveform data
step = Step(name="Initial step", test_result_id=test_result_id)
step_id = data_store_client.create_step(step)
published_measurement = data_store_client.publish_measurement(
published_measurement_id = data_store_client.publish_measurement(
name=name,
value=waveform,
step_id=step_id,
)
published_measurement = data_store_client.get_measurement(published_measurement_id)
print(
f"Published measurement: '{published_measurement.name}' with id {published_measurement.id}"
)

return published_measurement.id
return published_measurement_id


def query_data(published_measurement_id: str) -> None:
Expand Down
20 changes: 10 additions & 10 deletions examples/system/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ requires-poetry = '>=2.1,<3.0'
python = "^3.10"
protobuf = {version=">=4.21"}
ni-datamonikers-v1-client = { version = ">=0.1.0.dev1", allow-prereleases = true }
ni-measurements-data-v1-client = { version = ">=0.2.0.dev2", allow-prereleases = true }
ni-measurements-data-v1-client = { version = ">=0.2.0.dev4", allow-prereleases = true }
ni-measurements-metadata-v1-client = { version = ">=0.2.0.dev2", allow-prereleases = true }
ni-protobuf-types = { version = ">=1.0.1.dev0", allow-prereleases = true }
hightime = { version = ">=0.3.0.dev0", allow-prereleases = true }
Expand Down
Loading