Skip to content

tests: Enable system tests on Python 3.14 and fix failing generator tests #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkeryan merged 2 commits into from
Oct 28, 2025
Merged

tests: Enable system tests on Python 3.14 and fix failing generator tests #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33cb30
generator: Sort annotation keys to make tests pass on Python 3.14
bkeryan Oct 28, 2025
41c3b40
tests: Run system tests on Python 3.14
bkeryan Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ def get_configuration_and_output_metadata_by_index(
annotations_dict["ni/enum.values"] = _validate_and_transform_enum_annotations(
configuration.annotations["ni/enum.values"]
)

# In Python 3.13 and earlier, the ConfigurationParameter message sorted the annotation
# keys, but in Python 3.14, it started preserving order. Sort to keep tests passing.
annotations_dict = dict(sorted(annotations_dict.items()))

configuration_parameter_list.append(
ParameterMetadata.initialize(
display_name=configuration.name,
Expand Down Expand Up @@ -171,6 +176,11 @@ def get_configuration_and_output_metadata_by_index(
annotations_dict["ni/enum.values"] = _validate_and_transform_enum_annotations(
output.annotations["ni/enum.values"]
)

# In Python 3.13 and earlier, the ConfigurationParameter message sorted the annotation
# keys, but in Python 3.14, it started preserving order. Sort to keep tests passing.
annotations_dict = dict(sorted(annotations_dict.items()))

output_parameter_list.append(
ParameterMetadata.initialize(
display_name=output.name,
Expand Down
2 changes: 1 addition & 1 deletion packages/generator/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[tox]
isolated_build = true
envlist = clean, py{39,310,311,312,313}, py39-{pb4,pb5,pb6}
envlist = clean, py{39,310,311,312,313,314}, py39-{pb4,pb5,pb6}

[testenv]
skip_install = true
Expand Down
2 changes: 1 addition & 1 deletion packages/service/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[tox]
isolated_build = true
envlist = clean, py{39,310,311,312,313}-all-extras, py39-{pb4,pb5,pb6}
envlist = clean, py{39,310,311,312,313,314}-all-extras, py39-{pb4,pb5,pb6}

[testenv]
skip_install = true
Expand Down