Skip to content

Conversation

@olsl21
Copy link
Contributor

@olsl21 olsl21 commented May 22, 2025

  • This contribution adheres to CONTRIBUTING.md.
    - [ ] I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Remove the table of supported properties for create_advanced_sequence() in functions_addon.py that is outdated
    • Update its documentation text to redirect user to the "Supported Properties by Device" page on ni.com for the latest table of supported properties in advanced sequence

What testing has been done?

Local run of tox using Python 3.12.5 was successful, the generated HTML doc showed the expected content:
image

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (9efe042) to head (efd0f32).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2101   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files          66       66           
  Lines       16292    16292           
=======================================
+ Hits        14882    14883    +1     
+ Misses       1410     1409    -1     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests 94.59% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nidcpower/nidcpower/session.py 96.69% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efe042...efd0f32. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Remove the table of supported properties for `create_advanced_sequence()` in `functions_addon.py`
  - Update its documentation text to redirect user to the "Supported Properties by Device" page on `ni.com` for the latest table of supported properties in advanced sequence
@olsl21 olsl21 force-pushed the nidcpower-fix-create-advanced-sequence-doc-table branch from 3a582c7 to efd0f32 Compare May 22, 2025 11:37
@ni-jfitzger
Copy link
Collaborator

FYI @olsl21 we build the documentation on read the docs when you create the PR.
You can view the results there.
https://nidcpower--2101.org.readthedocs.build/en/2101/class.html#create-advanced-sequence

@ni-jfitzger
Copy link
Collaborator

Here's what happened with the system tests:

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

The self-hosted runner: i-09831d5cae436abef lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

This is only a documentation change, so I'm okay with the system tests not running. We could re-run them, but there's no point when there isn't a code change.

@ni-jfitzger ni-jfitzger merged commit e66d8ee into ni:master May 23, 2025
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants