Skip to content

Conversation

@batzuu
Copy link
Contributor

@batzuu batzuu commented Nov 6, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Updates NI-RFSG function metadata to prepare for upcoming gRPC support:

  • Adds grpc_name field where is a mismatch between expected gRPC parameter name and python name.
  • Adds/Updates grpc_enum field where is a mismatch between expected gRPC enum name and python enum name.

These changes are needed because ni/grpc-device has already shipped with these parameter and enum names, and we can’t change them without breaking the API. Also the mismatch comes from us expanding the parameter/enum names when adding them to python API metadata.

List issues fixed by this Pull Request

None

What testing has been done?

gRPC related fields in RFSG metadata are not consumed in the builds yet. These changes are prerequisite to allow us to enable gRPC codegen in upcoming PRs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.18%. Comparing base (7712396) to head (3f4654b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2136      +/-   ##
==========================================
+ Coverage   81.72%   89.18%   +7.45%     
==========================================
  Files          29       71      +42     
  Lines        4115    18960   +14845     
==========================================
+ Hits         3363    16909   +13546     
- Misses        752     2051    +1299     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (?)
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (?)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (?)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (?)
nimodinstsystemtests 73.85% <ø> (?)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 76.53% <ø> (?)
niscopesystemtests 92.94% <ø> (?)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (?)
niswitchsystemtests 82.03% <ø> (?)
nitclksystemtests 94.87% <ø> (?)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7712396...3f4654b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcoskirsch
Copy link
Member

Please look at the codecov results. Coverage should go up not down!

@ni-jfitzger
Copy link
Collaborator

Please look at the codecov results. Coverage should go up not down!

This was probably just the result of not all system tests having run, at the time. It seems fixed, now.

@ni-jfitzger ni-jfitzger merged commit cf435c0 into ni:master Nov 12, 2025
39 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants