Skip to content

refactor: LogSource enum #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikhilsinhaparseable merged 2 commits into from
Jan 5, 2025
Merged

refactor: LogSource enum #3

nikhilsinhaparseable merged 2 commits into from
Jan 5, 2025

Conversation

@de-sh
Copy link

@de-sh de-sh commented Jan 4, 2025

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as ready for review January 4, 2025 17:32
@nikhilsinhaparseable nikhilsinhaparseable merged commit 976e3fd into nikhilsinhaparseable:otel-metrics-traces-flattening Jan 5, 2025
4 of 7 checks passed
@de-sh de-sh deleted the otel-metrics-traces-flattening branch January 5, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@de-sh @nikhilsinhaparseable