-
Notifications
You must be signed in to change notification settings - Fork 24
fix(async): revert Promise.all refactor #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 80.79% 80.76% -0.03%
==========================================
Files 119 119
Lines 11864 11877 +13
Branches 843 841 -2
==========================================
+ Hits 9586 9593 +7
- Misses 2275 2281 +6
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts an accidental refactoring that changed sequential file processing to parallel processing using Promise.all. The change restores the original for-loop approach in both AST generators.
- Reverts
Promise.all()parallel processing back to sequentialfor...ofloops - Updates both markdown AST generator (
ast/index.mjs) and JavaScript AST generator (ast-js/index.mjs) for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/generators/ast/index.mjs | Reverts processChunk method from Promise.all with parallel map to sequential for-loop for processing markdown files |
| src/generators/ast-js/index.mjs | Reverts processChunk method from Promise.all with parallel map to sequential for-loop for processing JavaScript files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
During my hotfix, I appear to have accidentally changed a for-loop to a
Promise.all(in my attempt to use.map)That was not needed, so this is a revert of it.
cc @ovflowd