Skip to content

Conversation

@avivkeller
Copy link
Member

During my hotfix, I appear to have accidentally changed a for-loop to a Promise.all (in my attempt to use .map)

That was not needed, so this is a revert of it.

cc @ovflowd

Copilot AI review requested due to automatic review settings December 11, 2025 02:12
@vercel
Copy link

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Dec 11, 2025 2:17am

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.76%. Comparing base (06f981e) to head (0200966).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/ast/index.mjs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   80.79%   80.76%   -0.03%     
==========================================
  Files         119      119              
  Lines       11864    11877      +13     
  Branches      843      841       -2     
==========================================
+ Hits         9586     9593       +7     
- Misses       2275     2281       +6     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts an accidental refactoring that changed sequential file processing to parallel processing using Promise.all. The change restores the original for-loop approach in both AST generators.

  • Reverts Promise.all() parallel processing back to sequential for...of loops
  • Updates both markdown AST generator (ast/index.mjs) and JavaScript AST generator (ast-js/index.mjs) for consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/generators/ast/index.mjs Reverts processChunk method from Promise.all with parallel map to sequential for-loop for processing markdown files
src/generators/ast-js/index.mjs Reverts processChunk method from Promise.all with parallel map to sequential for-loop for processing JavaScript files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller marked this pull request as draft December 11, 2025 02:15
@ovflowd ovflowd merged commit 0e07e21 into main Dec 11, 2025
19 checks passed
@ovflowd ovflowd deleted the revert-refactor branch December 11, 2025 02:31
@ovflowd ovflowd added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants