Skip to content

fix(async): revert Promise.all refactor #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 2 commits into from
Dec 11, 2025
+23 −13
Merged

fix(async): revert Promise.all refactor #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ffd777
fix(async): revert Promise.all refactor
avivkeller Dec 11, 2025
0200966
fixup!
avivkeller Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/generators/ast-js/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,17 @@ export default {
async processChunk(inputSlice, itemIndices) {
const filePaths = itemIndices.map(idx => inputSlice[idx]);

return Promise.all(
filePaths.map(async path => parseJsSource(await read(path, 'utf-8')))
);
const results = [];

for (const path of filePaths) {
const vfile = await read(path, 'utf-8');

const parsedJS = await parseJsSource(vfile);

results.push(parsedJS);
}

return results;
},

/**
Expand Down
22 changes: 12 additions & 10 deletions src/generators/ast/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,20 @@ export default {
async processChunk(inputSlice, itemIndices) {
const filePaths = itemIndices.map(idx => inputSlice[idx]);

return Promise.all(
filePaths.map(async path => {
const vfile = await read(path, 'utf-8');
const results = [];

updateStabilityPrefixToLink(vfile);
for (const path of filePaths) {
const vfile = await read(path, 'utf-8');

return {
tree: remarkProcessor.parse(vfile),
file: { stem: vfile.stem, basename: vfile.basename },
};
})
);
updateStabilityPrefixToLink(vfile);

results.push({
tree: remarkProcessor.parse(vfile),
file: { stem: vfile.stem, basename: vfile.basename },
});
}

return results;
},

/**
Expand Down
Loading