chore: use toUpperCase in detectOS
#7241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CodingRule <ioumih32@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Also I can change it at utils/getNodeDownloadUrl.ts too |
avivkeller
reviewed
Nov 19, 2024
Signed-off-by: CodingRule <ioumih32@gmail.com>
Signed-off-by: CodingRule <ioumih32@gmail.com>
Contributor
Author
|
@redyetidev Done Thanks for pointing out to me that I can directly do it with uppercase and I have updated it in your sayings. Thanks! Hope this contribution will help. |
avivkeller
reviewed
Nov 19, 2024
avivkeller
changed the title
toUpperCase in detectOStoUpperCase in detectOS
avivkeller
approved these changes
Nov 19, 2024
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
See my one comment, then LGTM
Co-authored-by: Aviv Keller <redyetidev@gmail.com> Signed-off-by: CodingRule <ioumih32@gmail.com>
Contributor
Author
|
Haha thanks! I saw that one coming tbh (= |
Contributor
Author
thanks good sir! |
Contributor
Author
|
also quick question @redyetidev would I be able to apply the same logic here too? utils/getNodeDownloadUrl.ts too |
Member
|
In a seperate PR, preferably |
github-actions
bot
removed
the
github_actions:pull-request
Contributor
Author
|
yes ofc |
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
aymen94
approved these changes
Nov 19, 2024
Member
|
Thanks for your contribution, @CodingRule! It's be merged shortly. |
Contributor
Author
|
Ty! |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Update detectOS.ts Signed-off-by: CodingRule <ioumih32@gmail.com> * Update detectOS.ts Signed-off-by: CodingRule <ioumih32@gmail.com> * Update detectOS.ts Signed-off-by: CodingRule <ioumih32@gmail.com> * Update apps/site/util/detectOS.ts Co-authored-by: Aviv Keller <redyetidev@gmail.com> Signed-off-by: CodingRule <ioumih32@gmail.com> --------- Signed-off-by: CodingRule <ioumih32@gmail.com> Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the switch statement, we use a faster way with an object. Hope it's not useless tho.